From abdc50df99f51d7cc62fee8e255a71e6b59cd8b3 Mon Sep 17 00:00:00 2001
From: ahakanzn <a.hakan.zn@gmail.com>
Date: Tue, 13 Aug 2024 13:42:56 +0200
Subject: [PATCH] adding specific condition for handled params in documentation
 test (https://github.com/gbif/gbif-api/issues/137)

---
 .../LiteratureDocumentationTests.java         | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/src/test/java/org/gbif/literature/resource/LiteratureDocumentationTests.java b/src/test/java/org/gbif/literature/resource/LiteratureDocumentationTests.java
index cebead7..3483e48 100644
--- a/src/test/java/org/gbif/literature/resource/LiteratureDocumentationTests.java
+++ b/src/test/java/org/gbif/literature/resource/LiteratureDocumentationTests.java
@@ -13,10 +13,13 @@
  */
 package org.gbif.literature.resource;
 
+import io.swagger.v3.oas.annotations.Parameter;
+
 import org.gbif.api.model.literature.search.LiteratureSearchParameter;
 import org.gbif.literature.search.LiteratureEsFieldMapper;
 
 import java.util.Arrays;
+import java.util.HashSet;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -30,18 +33,29 @@ public class LiteratureDocumentationTests {
 
   @Test
   public void searchParametersDocumented() {
-    Set documentedParameters =
+
+    Set<LiteratureSearchParameter> handledParams = new HashSet<>(
+      Arrays.asList(
+        LiteratureSearchParameter.DOI,
+        LiteratureSearchParameter.ADDED,
+        LiteratureSearchParameter.PUBLISHED,
+        LiteratureSearchParameter.DISCOVERED,
+        LiteratureSearchParameter.MODIFIED
+      )
+    );
+
+    Set<String> documentedParameters =
         Arrays.stream(
                 LiteratureResource.CommonSearchParameters.class
                     .getAnnotation(Parameters.class)
                     .value())
-            .map(p -> p.name())
+            .map(Parameter::name)
             .collect(Collectors.toSet());
 
     LiteratureEsFieldMapper fieldMapper = new LiteratureEsFieldMapper();
 
     for (LiteratureSearchParameter param : LiteratureSearchParameter.values()) {
-      if (param == LiteratureSearchParameter.DOI) {
+      if (handledParams.contains(param)) {
         continue; // Handled specially.
       }
       String name = fieldMapper.get(param);