Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citationType field has inconsistent casing #52

Open
MattBlissett opened this issue Feb 23, 2023 · 5 comments
Open

citationType field has inconsistent casing #52

MattBlissett opened this issue Feb 23, 2023 · 5 comments

Comments

@MattBlissett
Copy link
Member

Untyped enumerations mean incomplete search results:

Maybe this should be an enumeration?

@dnoesgaard
Copy link
Member

I probably had a typo somewhere at some point. I've corrected the "Generic" ones to "generic". But it would be nice if the crawler used an enum.

@timrobertson100
Copy link
Member

A vocabulary might be appropriate, where the content crawler downloaded the full vocabulary on each run, allowing us to expand and add synonyms without code changes.

@dnoesgaard
Copy link
Member

That sounds interesting—and like something that could work for other fields as well, e.g. topics

@timrobertson100
Copy link
Member

and like something that could work for other fields as well, e.g. topics

Yes, plus it provides the definition of what the terms actually mean, should anyone be confused (e.g. future versions of ourselves).

@MattBlissett
Copy link
Member Author

Note three other fields already have enumerations, LiteratureRelevance, LiteratureTopic and LiteratureType: https://gbif.github.io/gbif-api/apidocs/org/gbif/api/model/literature/package-frame.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants