-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
citationType field has inconsistent casing #52
Comments
I probably had a typo somewhere at some point. I've corrected the "Generic" ones to "generic". But it would be nice if the crawler used an enum. |
A vocabulary might be appropriate, where the content crawler downloaded the full vocabulary on each run, allowing us to expand and add synonyms without code changes. |
That sounds interesting—and like something that could work for other fields as well, e.g. |
Yes, plus it provides the definition of what the terms actually mean, should anyone be confused (e.g. future versions of ourselves). |
Note three other fields already have enumerations, LiteratureRelevance, LiteratureTopic and LiteratureType: https://gbif.github.io/gbif-api/apidocs/org/gbif/api/model/literature/package-frame.html |
Untyped enumerations mean incomplete search results:
Maybe this should be an enumeration?
The text was updated successfully, but these errors were encountered: