Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should check code with clang-format and/or clang-tidy #1232

Open
Rangi42 opened this issue Nov 8, 2023 · 0 comments
Open

CI should check code with clang-format and/or clang-tidy #1232

Rangi42 opened this issue Nov 8, 2023 · 0 comments
Labels
builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership...

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Nov 8, 2023

We used to use checkpatch.pl, but it's for C, not C++, and doesn't follow the style conventions we want.

clang-tidy src/**/*.cpp -- -Iinclude -extra-arg=-std=c++20 gives lots of false positives (I might be using it wrong), but might be a good starting point for CI or at least a manual analysis.

Most files will need clang-formatting, plus manual work to get rid of old conventions like "blank line after declaration" and "no braces for single-statement control blocks".

@Rangi42 Rangi42 added the meta This isn't related to the tools directly: repo organization, maintainership... label Nov 8, 2023
@Rangi42 Rangi42 added this to the v0.8.0 milestone Nov 26, 2023
@Rangi42 Rangi42 removed this from the v0.9.0 milestone Aug 6, 2024
@Rangi42 Rangi42 changed the title Check code with clang-format and/or clang-tidy, not checkpatch.pl CI should check code with clang-format and/or clang-tidy Aug 7, 2024
@Rangi42 Rangi42 added the builds This affects the build process or release artifacts label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership...
Projects
None yet
Development

No branches or pull requests

1 participant