Update frame semantics docs #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
liamhan0905
reviewed
Oct 14, 2022
liamhan0905
reviewed
Oct 14, 2022
Signed-off-by: Steve Peters <[email protected]>
|
I'll take one last look during my flight on Monday with with fresh eyes before approving it |
The reserved name __model__ is used in the @expressed_in section but not defined elsewhere, so I've added it to the Canonical Link and Model Frame section. I also rearranged the sections so that the section about reserved names comes first. Signed-off-by: Steve Peters <[email protected]>
liamhan0905
reviewed
Oct 31, 2022
liamhan0905
reviewed
Oct 31, 2022
Signed-off-by: Steve Peters <[email protected]>
liamhan0905
approved these changes
Nov 1, 2022
|
LGTM |
Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing to work on #73, I noticed several issues with the Frame semantics documentation, so I started making some updates in this branch, but I got sidetracked before I could finish updating it all.
Preview: http://sdformat.org/tutorials?tut=pose_frame_semantics&cat=specification&branch=scpeters/update_frame_semantics_docs