Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on ign-utils and use ImplPtr #182

Open
chapulina opened this issue Dec 22, 2021 · 0 comments
Open

Depend on ign-utils and use ImplPtr #182

chapulina opened this issue Dec 22, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@chapulina
Copy link
Contributor

Ignition Utils provides a convenient PIMPL pointer implementation that would be great to use in ign-sensors.

Desired behavior

Sensor implementations can use ImplPtr instead of std::unique_ptr, which requires IGN_COMMON_WARN_IGNORE__DLL_INTERFACE_MISSING.

Alternatives considered

Leave things the way they are.

Implementation suggestion

This change breaks ABI, so it should target the main branch.

  1. Add ign-utils as a direct dependency of ign-sensors
  2. Use ImplPtr for all dataPtrs in ign-sensors. As an example, see how it was done for SDFormat in Update classes to use ignition::utils::ImplPtr or ignition::utils::UniqueImplPtr  sdformat#474
@chapulina chapulina added enhancement New feature or request help wanted Extra attention is needed labels Dec 22, 2021
@chapulina chapulina mentioned this issue Dec 22, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chapulina