Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify GDAL version requirement #574

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Clarify GDAL version requirement #574

merged 1 commit into from
Jan 29, 2024

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Jan 26, 2024

🦟 Bug fix

Summary

The default behavior of pkg-config seems to be an exact version match.

This was discovered when the RPM build process automatically added package dependencies based on the *.pc files generated by the project, one of which contained gdal = 3.0. This bug can be confirmed on any distro that has a gdal version other than 3.0, such as Ubuntu Jammy:

$ pkg-config --cflags gz-common5-geospatial
Package 'gz-common5-geospatial' requires 'gdal = 3.0' but version of gdal is 3.4.1
$ echo $?
1

It's interesting that the version comparison behaves differently in the first dependency level (which did not produce an error) than it does in subsequent levels. Perhaps there is a bug in gz-cmake as well.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The default behavior of pkg-config seems to be an exact version match.

Signed-off-by: Scott K Logan <[email protected]>
@cottsay cottsay requested a review from marcoag as a code owner January 26, 2024 02:52
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b8428a) 83.65% compared to head (f6372e4) 83.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-common5     #574   +/-   ##
===========================================
  Coverage       83.65%   83.65%           
===========================================
  Files              90       90           
  Lines           10273    10273           
===========================================
  Hits             8594     8594           
  Misses           1679     1679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit e9dbca7 into gazebosim:gz-common5 Jan 29, 2024
15 checks passed
@cottsay cottsay deleted the gdal-requirement branch January 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants