Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bit DEM data will silently report lossy NoData values #608

Open
Ryanf55 opened this issue May 10, 2024 · 0 comments
Open

64 bit DEM data will silently report lossy NoData values #608

Ryanf55 opened this issue May 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Ryanf55
Copy link
Contributor

Ryanf55 commented May 10, 2024

Environment

  • OS Version: Ubuntu 24
  • Source or binary build?
    Binary

Description

  • Expected behavior: If 64 bit datasets are not supported yet, a user attempting to load one should get a warning/error that it's not yet supported
  • Actual behavior: 64 bit nodata is silently handled incorrectly

GDAL has separate API's for 64 bit datasets, such as GetNoDataValueAsInt64

Per the docs: For rasters of type GDT_Int64 or GDT_UInt64, using this method might be lossy if the nodata value cannot exactly been represented by a double. The current method used in gz-common is only GetNoDataValue.

Ubuntu 22 ships with GDAL 3.4, which does not support 64 bit versions of GDAL, so these terrains can not be loaded. Newer platforms make that possible.

I would consider this use case small, so the easiest solution would just to report a warning it's not yet supported. I don't think many people use data that precise.

Steps to reproduce

TODO

  1. Finda 64 bit dataset with NoData values

  2. Load it

  3. Check the NoData value is not correct

Output

TODO

@Ryanf55 Ryanf55 added the bug Something isn't working label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant