Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginSpecialization test flaking on Actions #177

Open
chapulina opened this issue Mar 4, 2021 · 0 comments
Open

PluginSpecialization test flaking on Actions #177

chapulina opened this issue Mar 4, 2021 · 0 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed tests Broken or missing tests / testing infra

Comments

@chapulina
Copy link
Contributor

Environment

  • OS Version: Ubuntu
  • Source or binary build? source, main

Description

The plugin specialization performance test is flaky on GitHub actions for Focal:

  [ RUN      ] PluginSpecialization.AccessTime
  /github/workspace/test/performance/plugin_specialization.cc:204: Failure
  Expected: (std::abs(tests[2].avg - baseline)) < (baseline), actual: 2.97 vs 2.91
   --- 1 specialization result ---
  Avg time:    0.005400ns
  
   --- 3 specializations (leading) result ---
  Avg time:    0.002910ns
  
   --- 3 specializations (trailing) result ---
  Avg time:    0.005880ns
  
   --- 10 specializations (leading) result ---
  Avg time:    0.002570ns
  
   --- 10 specializations (trailing) result ---
  Avg time:    0.002760ns
  
   --- 20 specializations (leading) result ---
  Avg time:    0.002450ns
  
   --- 20 specializations (trailing) result ---
  Avg time:    0.002650ns
  
   --- No specialization result ---
  Avg time:  152.939648ns
  
  [  FAILED  ] PluginSpecialization.AccessTime (1615 ms)

Considering that common::Plugin will be deprecated soon, I think we shouldn't spend time investigating and instead relax that test.

Steps to reproduce

Run CI for the main branch a few times.

@chapulina chapulina added bug Something isn't working tests Broken or missing tests / testing infra labels Mar 4, 2021
@chapulina chapulina added the help wanted Extra attention is needed label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed tests Broken or missing tests / testing infra
Projects
None yet
Development

No branches or pull requests

2 participants