Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release.py fails for ignition packages #1102

Closed
azeey opened this issue Jan 5, 2024 · 5 comments · Fixed by #1105
Closed

release.py fails for ignition packages #1102

azeey opened this issue Jan 5, 2024 · 5 comments · Fixed by #1105
Assignees

Comments

@azeey
Copy link
Contributor

azeey commented Jan 5, 2024

Tested with ign-math6:

release.py  -r 1 --dry-run ign-math6 6.15.1 faketoken
Downloading releasing info for ign-math6
Linux distributions in the -release repository:
 + focal  ('amd64', 'armhf', 'arm64')
 + jammy  ('amd64', 'armhf', 'arm64')
Safety checks:
 + OK No underscore in package name

 !! Error in changelog package name or alias: ignition-math6 (6.15.1-1~focal) focal; urgency=medium

Running the same command with a version of release.py before #1014 succeeds. For references, the working version is in cf72fde.

cc @iche033.

j-rivero added a commit that referenced this issue Jan 8, 2024
Fix #1102

Signed-off-by: Jose Luis Rivero <[email protected]>
@azeey
Copy link
Contributor Author

azeey commented Jan 12, 2024

This is still failing for me. I tried to release ign-sensors6 and this is what I got

$ release.py  -r 1 --dry-run ign-sensors6 6.8.0   testtoken
Downloading releasing info for ign-sensors6
Linux distributions in the -release repository:
 + focal  ('amd64', 'armhf', 'arm64')
 + jammy  ('amd64', 'armhf', 'arm64')
Safety checks:
 + OK No underscore in package name
 + OK Package names in changelog and control
 + OK Package versions in changelog
 + OK Package release versions in changelog
 + OK sdformat version in proper sdformat package
 !! Automatic calculation of source_repo_uri failed.
   * git remote origin is: https://github.com/gazebosim/gz-sensors
   * Package name generated org/repo: gazebosim/ignition-sensors
 >> Please use --source-repo-uri parameter

@azeey azeey reopened this Jan 12, 2024
@j-rivero
Copy link
Contributor

This is an expected effect of the failure of the safety measure to be sure what is the source repository desired by crossing the results of:

  • git remote origin in the current directory, in this case https://github.com/gazebosim/gz-sensors
  • reconstruction of org/repo by adding package alias to gazebosim, in this case gazebosim/ignition-sensors

Since both methods don't match the script refuse to continue and suggests:

 >> Please use --source-repo-uri parameter

So:

release.py  -r 1 --dry-run ign-sensors6 6.8.0   testtoken --source-repo-uri  https://github.com/gazebosim/gz-sensors.git

should make it.

To improve the user experience I can tweak the script to deal with these ignition cases and/or improve the error message to help the user to understand what he/she should do.

@j-rivero
Copy link
Contributor

After releasing ign-gazebo6 using PR #1109 I'm going to proceed to rename the ign- debbuilder to use the new gz- names.

@j-rivero
Copy link
Contributor

j-rivero commented May 7, 2024

Renamed jobs: rendering6 and ign-gazebo6 were already renamed.

Renaming Job 'ign-cmake2-debbuilder' to 'gz-cmake2-debbuilder'
Renaming Job 'ign-common3-debbuilder' to 'gz-common3-debbuilder'
Renaming Job 'ign-common4-debbuilder' to 'gz-common4-debbuilder'
Renaming Job 'ign-fuel-tools7-debbuilder' to 'gz-fuel-tools7-debbuilder'
Renaming Job 'ign-gui3-debbuilder' to 'gz-gui3-debbuilder'
Renaming Job 'ign-gui6-debbuilder' to 'gz-gui6-debbuilder'
Renaming Job 'ign-launch2-debbuilder' to 'gz-launch2-debbuilder'
Renaming Job 'ign-launch5-debbuilder' to 'gz-launch5-debbuilder'
Renaming Job 'ign-math6-debbuilder' to 'gz-math6-debbuilder'
Renaming Job 'ign-msgs5-debbuilder' to 'gz-msgs5-debbuilder'
Renaming Job 'ign-msgs8-debbuilder' to 'gz-msgs8-debbuilder'
Renaming Job 'ign-physics2-debbuilder' to 'gz-physics2-debbuilder'
Renaming Job 'ign-physics5-debbuilder' to 'gz-physics5-debbuilder'
Renaming Job 'ign-plugin-debbuilder' to 'gz-plugin-debbuilder'
Renaming Job 'ign-rendering3-debbuilder' to 'gz-rendering3-debbuilder'
Job 'gz-rendering6-debbuilder' already exists and has builds. Probably migrated
Renaming Job 'ign-sensors3-debbuilder' to 'gz-sensors3-debbuilder'
Renaming Job 'ign-sensors6-debbuilder' to 'gz-sensors6-debbuilder'
Renaming Job 'ign-tools-debbuilder' to 'gz-tools-debbuilder'
Renaming Job 'ign-transport11-debbuilder' to 'gz-transport11-debbuilder'
Renaming Job 'ign-transport8-debbuilder' to 'gz-transport8-debbuilder'
Renaming Job 'ign-utils1-debbuilder' to 'gz-utils1-debbuilder'
Result: [ign-cmake2-debbuilder, ign-common3-debbuilder, ign-common4-debbuilder, ign-fuel-tools7-debbuilder, ign-gui3-debbuilder, ign-gui6-debbuilder, ign-launch2-debbuilder, ign-launch5-debbuilder, ign-math6-debbuilder, ign-msgs5-debbuilder, ign-msgs8-debbuilder, ign-physics2-debbuilder, ign-physics5-debbuilder, ign-plugin-debbuilder, ign-rendering3-debbuilder, ign-rendering6-debbuilder, ign-sensors3-debbuilder, ign-sensors6-debbuilder, ign-tools-debbuilder, ign-transport11-debbuilder, ign-transport8-debbuilder, ign-utils1-debbuilder]

@j-rivero
Copy link
Contributor

Should be now ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants