Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove chucnked output for now #129

Conversation

garymm
Copy link
Owner

@garymm garymm commented Feb 12, 2024

remove chucnked output for now

It adds too much complexity. I want to focus on the basics.

Change-Id: I45c0da75d8a3c81eb20a982c8ccba6a1c87b2374

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (I033a4b201c72fe43e70702eed3c4098666398c1d@c33afb7). Click here to learn what that means.

❗ Current head 9e107e7 differs from pull request most recent head 226f114. Consider uploading reports for the commit 226f114 to get more accurate results

Files Patch % Lines
src/decompress.cpp 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##             I033a4b201c72fe43e70702eed3c4098666398c1d     #129   +/-   ##
============================================================================
  Coverage                                             ?   82.88%           
============================================================================
  Files                                                ?       16           
  Lines                                                ?      625           
  Branches                                             ?       38           
============================================================================
  Hits                                                 ?      518           
  Misses                                               ?       92           
  Partials                                             ?       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garymm garymm marked this pull request as ready for review February 12, 2024 23:06
@garymm garymm enabled auto-merge (squash) February 12, 2024 23:06
Copy link
Collaborator

@oliverlee oliverlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in commit message

src/test/decompress_test.cpp Show resolved Hide resolved
@garymm garymm changed the title remove chucnked output for now remove chunked output for now Feb 13, 2024
@garymm garymm force-pushed the I45c0da75d8a3c81eb20a982c8ccba6a1c87b2374 branch from d1a735e to 9e107e7 Compare March 9, 2024 15:10
@garymm garymm changed the title remove chunked output for now remove chucnked output for now Mar 9, 2024
It adds too much complexity. I want to focus on the basics.

Change-Id: I45c0da75d8a3c81eb20a982c8ccba6a1c87b2374
@garymm garymm force-pushed the I45c0da75d8a3c81eb20a982c8ccba6a1c87b2374 branch from 9e107e7 to 226f114 Compare March 9, 2024 15:22
@garymm garymm changed the base branch from master to I033a4b201c72fe43e70702eed3c4098666398c1d March 9, 2024 15:22
@garymm garymm merged commit 3e6fbcd into I033a4b201c72fe43e70702eed3c4098666398c1d Mar 9, 2024
5 of 6 checks passed
@garymm garymm deleted the I45c0da75d8a3c81eb20a982c8ccba6a1c87b2374 branch March 9, 2024 15:22
@oliverlee
Copy link
Collaborator

did this get merged into the wrong base?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants