Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from custom autoscaler fork for MCM Provider to gRPC pluggable provider #783

Open
elankath opened this issue Feb 15, 2023 · 0 comments
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/4 Priority (lower number equals higher priority)

Comments

@elankath
Copy link
Contributor

elankath commented Feb 15, 2023

How to categorize this issue?

/area control-plane
/area auto-scaling
/kind enhancement
/priority 3

What would you like to be added:
Today the gardener MCM team manages a custom fork of k8s cluster autoscaler that includes code which implements the cloudprovider.CloudProvider interface. This involves regular maintenance, resolving merge conflicts, associated testing, management of custom images etc.

However, the autoscaler has in the last year provided a mechanism to inject custom providers via gRPC obviating the need for separate fork maintenance. This is described here: Pluggable gRPC provider mechanism and the calling gRPC client is present here: External gRPC Client

The enhancement request is to implement our MCM controller as an external gRPC cloud provider, remove our custom autoscaler image and leverage the standard autoscaler image with all associated and necessary changes in testing/deployment/rollout.

Why is this needed:

This has also been mentioned as an issue in our autoscaler fork: gardener/autoscaler#172

@elankath elankath added the kind/enhancement Enhancement, improvement, extension label Feb 15, 2023
@himanshu-kun himanshu-kun added priority/4 Priority (lower number equals higher priority) needs/planning Needs (more) planning with other MCM maintainers kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly area/dev-productivity Developer productivity related (how to improve development) labels Feb 24, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 3, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/4 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants