Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify missing expected router %s as user error #852

Open
Kostov6 opened this issue Sep 11, 2024 · 1 comment
Open

Classify missing expected router %s as user error #852

Kostov6 opened this issue Sep 11, 2024 · 1 comment
Assignees
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure

Comments

@Kostov6
Copy link
Contributor

Kostov6 commented Sep 11, 2024

How to categorize this issue?

/area quality
/kind enhancement
/platform openstack

What would you like to be added:

router, err := fctx.access.GetRouterByID(fctx.config.Networks.Router.ID)
if err != nil {
fctx.state.Set(IdentifierRouter, "")
fctx.state.Set(RouterIP, "")
return err
}
if router == nil {
fctx.state.Set(IdentifierRouter, "")
fctx.state.Set(RouterIP, "")
return fmt.Errorf("missing expected router %s", fctx.config.Networks.Router.ID)

Could be tagged as user error

Why is this needed:
Improved error classification

@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure labels Sep 11, 2024
@Kostov6
Copy link
Contributor Author

Kostov6 commented Sep 11, 2024

/assign Kostov6

@Kostov6 Kostov6 changed the title Tag missing expected router %s as user error Classify missing expected router %s as user error Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants