Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disruptive changes to Shoot ETCD #499

Open
elenz97 opened this issue Sep 28, 2022 · 0 comments
Open

Avoid disruptive changes to Shoot ETCD #499

elenz97 opened this issue Sep 28, 2022 · 0 comments
Labels
area/control-plane Control plane related area/robustness Robustness, reliability, resilience related lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@elenz97
Copy link
Contributor

elenz97 commented Sep 28, 2022

How to categorize this issue?

/area robustness
/area control-plane

What would you like to be added:

In our Gardener setup, we are required to use our own StorageClass for the Shoot ETCD component.
As far as I can understand how a shoot ETCD is provisioned, the StorageClass will always be obtained from the provided config.etcd.storage configuration from the gardener-extension-provider-openstack helm chart. After the initial reconciliation of a shoot cluster, changing the .storage configuration to reference a custom StorageClass could then disrupt existing ETCD deployments, as its volumeClaimTemplates will ultimately be overridden1.
I'd like to propose adding a safeguard in EnsureETCD()1 to ensure the configured StorageClass will not be altered when modifying the storage configuration.

Why is this needed:

To not disrupt existing ETCD deployments by modifying the storage configuration via the helm chart.

Footnotes

  1. https://github.com/gardener/gardener-extension-provider-openstack/blob/master/pkg/webhook/controlplaneexposure/ensurer.go#L88 2

@gardener-robot gardener-robot added area/control-plane Control plane related area/robustness Robustness, reliability, resilience related labels Sep 28, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 7, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related area/robustness Robustness, reliability, resilience related lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants