Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm /v1-suffix for serialisation of helmchart-type #1058

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Oct 16, 2024

OCM-CLI/OCM-Spec seem to not allow/know v1-suffix for helmchart-artefacts. Thus, change deserialisation output to just helmChart. Keep support for alias with v1-suffix for compatibility.

OCM-CLI/OCM-Spec seem to not allow/know v1-suffix for helmchart-artefacts. Thus, change deserialisation output to just helmChart. Keep support for alias _with_ v1-suffix for compatibility.
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 16, 2024
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 16, 2024
Copy link

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ccwienk ccwienk merged commit f5307c7 into master Oct 16, 2024
12 checks passed
@ccwienk ccwienk deleted the fix-helmchart-type branch October 16, 2024 08:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants