Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update machinedeployments list dynamically #29

Open
Tracked by #180
rewiko opened this issue Feb 3, 2020 · 1 comment
Open
Tracked by #180

[Feature] Update machinedeployments list dynamically #29

rewiko opened this issue Feb 3, 2020 · 1 comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/documentation Needs (more) documentation needs/update-doc Needs updation of doc/ FAQ so customers are aware of this

Comments

@rewiko
Copy link

rewiko commented Feb 3, 2020

Based on https://github.com/gardener/autoscaler/blob/machine-controller-manager/cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go#L155
Cluster-autoscaler with mcm provider do not implement autodiscovery of machinedeployments, Min, Max and autoscaling: true fields could be created in MCM to allow CA to get all machines deployment with autoscaling enabled.

Also when the static list is used, a check should be added make sure the machinedeployment exists. The refresh function will refresh the list from time to time.

For the moment if you define a machinedeployment as parameter to CA and this one do not exist the CA autoscaler will stop scaling the cluster even if some other machinedeployments are available for scaling.

@rewiko rewiko changed the title [Feature] Implement this method to update the machinedeployments dynamically [Feature] Update machinedeployments dynamically Feb 3, 2020
@rewiko rewiko changed the title [Feature] Update machinedeployments dynamically [Feature] Update machinedeployments list dynamically Feb 3, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 4, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 4, 2020
@prashanth26 prashanth26 added kind/enhancement Enhancement, improvement, extension and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) labels Aug 16, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 16, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 16, 2020
@himanshu-kun himanshu-kun removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Feb 27, 2023
@himanshu-kun
Copy link

Post grooming decision

We are going to add FAQ for a stand-alone usage to be aware of the issues that can arise.

@himanshu-kun himanshu-kun added needs/documentation Needs (more) documentation lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) needs/update-doc Needs updation of doc/ FAQ so customers are aware of this labels Feb 27, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 8, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/documentation Needs (more) documentation needs/update-doc Needs updation of doc/ FAQ so customers are aware of this
Projects
None yet
Development

No branches or pull requests

4 participants