Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject command is overly complex #24

Open
DrTexx opened this issue Mar 30, 2020 · 1 comment
Open

Inject command is overly complex #24

DrTexx opened this issue Mar 30, 2020 · 1 comment
Assignees
Labels
refactor Refactoring required

Comments

@DrTexx
Copy link
Contributor

DrTexx commented Mar 30, 2020

This function looks very complex, would be good to have a chat about whether this can be condensed down to one or two core functions, or possibly rely on a battle-tested import.

At a minimum it would be good to abstract away all the conditionals, error checking and comments around logging to make the core functionality a bit clearer

Originally posted by @rozifus in https://github.com/flex-dapps/gantree-lib-nodejs/pull/23

@DrTexx DrTexx added the refactor Refactoring required label Apr 6, 2020
@DrTexx DrTexx self-assigned this Apr 6, 2020
@DrTexx
Copy link
Contributor Author

DrTexx commented Jun 11, 2020

Progress has been made on this front in the last few weeks thanks to @rozifus.
I will close this issue once the refactor has been merged to a stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring required
Projects
None yet
Development

No branches or pull requests

1 participant