-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13 support #18449
Add Python 3.13 support #18449
Conversation
d124b6e
to
539a24b
Compare
7e958b2
to
4205c4d
Compare
643fa4c
to
393f952
Compare
https://pypi.org/project/h5py/3.12.1/ :-)
|
Just 2 dependencies left, then |
I would try to keep that functionality if it all possible ? Having this proven track record of being able to re-run old jobs feels like something pretty important. |
2a41350
to
714a1f8
Compare
Only mercurial is left 🎉
@mvdbeek This should now be handled by the workaround I've added in the commit "Use fissix to replace lib2to3 under Python >=3.13". Let me know if that looks good to you. |
27075ea
to
5b2fd54
Compare
This is now out of draft, although it would make sense to merge #19075 first (which should be ready in a couple of days). |
Also: - Cheetah3 package on PyPI has been renamed to CT3 since 3.3.0, see https://cheetahtemplate.org/news.html
which has been removed in the upcoming Python 3.13 .
Add entries to `sys.modules` so that `future`/`past` can find lib2to3 modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Integration test failure unrelated.
xref. #16854
Standard library issues:
lib/galaxy/util/template.py
and is also used byfuture
Compatibility with Python-3.13 PythonCharmers/python-future#640 . https://github.com/amyreese/fissix could be a drop-in replacement for lib2to3, but unit tests break unless alsofuture
uses it.Package issues:
hg
script breaks under Python 3.13 https://bz.mercurial-scm.org/show_bug.cgi?id=6926 Repo . Fixed in mercurial 6.8.2cgi
DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13 Pylons/webob#437 . Fixed in WebOb 1.8.9How to test the changes?
(Select all options that apply)
License