Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support #18449

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Add Python 3.13 support #18449

merged 4 commits into from
Oct 31, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jun 28, 2024

xref. #16854

Standard library issues:

Package issues:

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mr-c
Copy link
Contributor

mr-c commented Sep 27, 2024

https://pypi.org/project/h5py/3.12.1/ :-)
https://docs.h5py.org/en/stable/whatsnew/3.12.html#new-features

h5py now has pre-built packages for Python 3.13.

@nsoranzo
Copy link
Member Author

nsoranzo commented Oct 2, 2024

Just 2 dependencies left, then lib2to3 should hopefully be the only remaining issue.
@mvdbeek What's your thinking about lib2to3? Should we try to add it to future, or just get rid of it from our code base, or something else?

@mvdbeek
Copy link
Member

mvdbeek commented Oct 2, 2024

I would try to keep that functionality if it all possible ? Having this proven track record of being able to re-run old jobs feels like something pretty important.

@nsoranzo
Copy link
Member Author

nsoranzo commented Oct 24, 2024

Only mercurial is left 🎉

I would try to keep that functionality if it all possible ? Having this proven track record of being able to re-run old jobs feels like something pretty important.

@mvdbeek This should now be handled by the workaround I've added in the commit "Use fissix to replace lib2to3 under Python >=3.13". Let me know if that looks good to you.

@nsoranzo nsoranzo force-pushed the python3.13 branch 3 times, most recently from 27075ea to 5b2fd54 Compare October 24, 2024 16:34
@nsoranzo nsoranzo changed the title [WIP] Add Python 3.13 support Add Python 3.13 support Oct 29, 2024
@nsoranzo nsoranzo marked this pull request as ready for review October 29, 2024 15:51
@github-actions github-actions bot added this to the 24.2 milestone Oct 29, 2024
@nsoranzo
Copy link
Member Author

This is now out of draft, although it would make sense to merge #19075 first (which should be ready in a couple of days).

Also:
- Cheetah3 package on PyPI has been renamed to CT3 since 3.3.0, see
  https://cheetahtemplate.org/news.html
which has been removed in the upcoming Python 3.13 .
Add entries to `sys.modules` so that `future`/`past` can find
lib2to3 modules.
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Integration test failure unrelated.

@nsoranzo nsoranzo merged commit 80ce8ad into galaxyproject:dev Oct 31, 2024
56 of 57 checks passed
@nsoranzo nsoranzo deleted the python3.13 branch October 31, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants