Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Spot price calculation with share asset within stablepool #869

Closed
dmoka opened this issue Jul 19, 2024 · 1 comment
Closed

Bug: Spot price calculation with share asset within stablepool #869

dmoka opened this issue Jul 19, 2024 · 1 comment

Comments

@dmoka
Copy link
Contributor

dmoka commented Jul 19, 2024 •
edited
Loading

This check prevents the spot price calculation between share and stable asset: https://github.com/galacticcouncil/HydraDX-wasm/blob/d0e8a31b7c9aedef3344d8aed9b05e9185fb89d2/src/lib.rs#L751-L753

We want an && instead of || in the check.

Optionall, we could check if assets that is not in reserves is pool_id.
@dmoka
Copy link
Contributor Author

dmoka commented Aug 5, 2024

Closed as tracked in the source repo: galacticcouncil/HydraDX-wasm#32

@dmoka dmoka closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmoka