Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test timeout #1733

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@GuoLei1990 GuoLei1990 added test unit test ignore for release ignore for release labels Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.12% 🎉

Comparison is base (40f6ab4) 62.17% compared to head (f71e6bf) 62.29%.
Report is 8 commits behind head on dev/1.1.

❗ Current head f71e6bf differs from pull request most recent head 5b51a13. Consider uploading reports for the commit 5b51a13 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.1    #1733      +/-   ##
===========================================
+ Coverage    62.17%   62.29%   +0.12%     
===========================================
  Files          430      430              
  Lines        22542    22545       +3     
  Branches      3202     3203       +1     
===========================================
+ Hits         14015    14045      +30     
+ Misses        7300     7280      -20     
+ Partials      1227     1220       -7     
Files Changed Coverage Δ
packages/loader/src/SceneLoader.ts 6.77% <0.00%> (-0.37%) ⬇️
packages/core/src/mesh/SkinnedMeshRenderer.ts 61.87% <71.42%> (+6.87%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit d25a168 into galacean:dev/1.1 Sep 5, 2023
5 checks passed
@GuoLei1990 GuoLei1990 deleted the pr/fix-timeout-2 branch September 18, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release test unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant