Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay add scene can't fire onEnbaleInScene bug #1725

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Sep 1, 2023
@GuoLei1990 GuoLei1990 linked an issue Sep 1, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 74.63% and project coverage change: +0.78% 🎉

Comparison is base (ef443a3) 61.37% compared to head (a8a7b03) 62.16%.
Report is 28 commits behind head on dev/1.1.

❗ Current head a8a7b03 differs from pull request most recent head b074344. Consider uploading reports for the commit b074344 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.1    #1725      +/-   ##
===========================================
+ Coverage    61.37%   62.16%   +0.78%     
===========================================
  Files          410      430      +20     
  Lines        21834    22542     +708     
  Branches      3140     3202      +62     
===========================================
+ Hits         13401    14013     +612     
- Misses        7244     7300      +56     
- Partials      1189     1229      +40     
Files Changed Coverage Δ
packages/core/src/Entity.ts 83.69% <0.00%> (-0.26%) ⬇️
packages/core/src/SceneManager.ts 52.38% <0.00%> (ø)
packages/core/src/asset/Loader.ts 83.33% <ø> (ø)
packages/core/src/material/Material.ts 94.59% <0.00%> (-2.63%) ⬇️
...ckages/core/src/shadow/CascadedShadowCasterPass.ts 31.97% <ø> (ø)
packages/loader/src/SceneLoader.ts 7.14% <ø> (+0.12%) ⬆️
.../loader/src/gltf/extensions/GLTFExtensionParser.ts 55.55% <ø> (-4.45%) ⬇️
...ader/src/gltf/extensions/KHR_materials_variants.ts 20.00% <0.00%> (ø)
...s/loader/src/gltf/extensions/KHR_texture_basisu.ts 7.40% <ø> (+0.26%) ⬆️
packages/loader/src/gltf/parser/GLTFParser.ts 81.57% <ø> (+3.00%) ⬆️
... and 30 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 8e94cc3 into galacean:dev/1.1 Sep 1, 2023
5 checks passed
@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Sep 1, 2023
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 2, 2023
* dev/1.1:
  Fix delay add scene can't fire `onEnbaleInScene` bug (galacean#1725)
  Fix multi scene script error and GC problem (galacean#1724)
  fix: glTF parser error and test case (galacean#1723)
  fix: Script onDisable error (galacean#1719)
  "v1.1.0-alpha.2"
  Add physic unit test timeout (galacean#1717)
  "v1.0.0-beta.20"
  Fix `PhysicManager`  fixedTimeStep less than 0 bug (galacean#1715)
  Fix physx unit test (galacean#1714)
  Fix a series of physical system problems (galacean#1712)
  Fix avoid destroyed material error (galacean#1705)

# Conflicts:
#	packages/core/package.json
#	packages/design/package.json
#	packages/draco/package.json
#	packages/galacean/package.json
#	packages/loader/package.json
#	packages/math/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
@GuoLei1990 GuoLei1990 deleted the pr/fix-delay-add-scene-bug branch September 18, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi scene error
1 participant