Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text error for set text to "" and set enableWrapping to true #1634

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Fix text error for set text to "" and set enableWrapping to true #1634

merged 3 commits into from
Jul 10, 2023

Conversation

singlecoder
Copy link
Member

…o true

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@singlecoder singlecoder added the bug Something isn't working label Jul 5, 2023
@singlecoder singlecoder added this to the 1.0 milestone Jul 5, 2023
@singlecoder singlecoder self-assigned this Jul 5, 2023
cptbtptpbcptdtptp
cptbtptpbcptdtptp approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

jtabibito
jtabibito reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jtabibito jtabibito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed.

@jtabibito jtabibito self-requested a review July 5, 2023 07:06
jtabibito
jtabibito reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jtabibito jtabibito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 added the text 2D text system label Jul 10, 2023
GuoLei1990
GuoLei1990 requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test when text is "" and error

@GuoLei1990 GuoLei1990 merged commit ceb7b48 into galacean:main Jul 10, 2023
5 checks passed
GuoLei1990 added a commit that referenced this pull request Aug 1, 2023
@GuoLei1990
Merge branch 'main' into dev/1.1
d64b320 
* main: (41 commits)
  fix: skin mesh error (#1675)
  fix: test error (#1674)
  test: fix ci not work (#1670)
  fix: `EventDispatcher` static pool bug
  fix: eventdispatcher bug (#1671)
  fix: animation event bug (#1666)
  Fix parse glTF texture wrap & filterMode bug (#1659)
  Fix text wrap bug (#1644)
  chore: use strict error msg and type (#1647)
  Fix text error for set text to "" and set enableWrapping to true (#1634)
  "v1.0.0-beta.17"
  Process GLTFBufferParser and GLTFTextureParser pipelines in parallel (#1638)
  Fix animation clip loader, clip change promise to assetPromise, controller json parse (#1506)
  fix: the layer is not cloned when the node is cloned (#1636)
  Fix glTF texture mipmap bug (#1637)
  "v1.0.0-beta.16"
  Adjust main light to directional lights first (#1635)
  Fix  `AmbientLight` can't destroy bug (#1633)
  Add value change listener for `Sprite` (#1622)
  Add unit test case of `Font` (#1606)
  ...
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Aug 2, 2023
@GuoLei1990
Merge branch 'dev/1.1' into pr/deth-texture
d2d0ac3 
* dev/1.1: (48 commits)
  fix: skin mesh error (galacean#1675)
  fix: test error (galacean#1674)
  test: fix github test (galacean#1669)
  test: fix ci not work (galacean#1670)
  glTF support basisu (galacean#1662)
  fix: `EventDispatcher` static pool bug
  fix: eventdispatcher bug (galacean#1671)
  fix: animation event bug (galacean#1666)
  Shader pass support blend (galacean#1668)
  Fix model mesh advanced data write bug (galacean#1663)
  Cherry pick glTF conflict (galacean#1660)
  Fix worker status set error and can't throw error bug (galacean#1652)
  Fix parse glTF texture wrap & filterMode bug (galacean#1659)
  Add shader lab package and support shader framework (galacean#1610)
  Fix text wrap bug (galacean#1644)
  chore: use strict error msg and type (galacean#1647)
  Fix text error for set text to "" and set enableWrapping to true (galacean#1634)
  "v1.0.0-beta.17"
  Process GLTFBufferParser and GLTFTextureParser pipelines in parallel (galacean#1638)
  Fix animation clip loader, clip change promise to assetPromise, controller json parse (galacean#1506)
  ...
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Aug 3, 2023
@GuoLei1990
Merge branch 'dev/1.1' into PR/fix-skin-lazy
22328a9 
* dev/1.1: (43 commits)
  fix: skin mesh error (galacean#1675)
  fix: test error (galacean#1674)
  test: fix github test (galacean#1669)
  test: fix ci not work (galacean#1670)
  glTF support basisu (galacean#1662)
  fix: `EventDispatcher` static pool bug
  fix: eventdispatcher bug (galacean#1671)
  fix: animation event bug (galacean#1666)
  Fix parse glTF texture wrap & filterMode bug (galacean#1659)
  Fix text wrap bug (galacean#1644)
  chore: use strict error msg and type (galacean#1647)
  Fix text error for set text to "" and set enableWrapping to true (galacean#1634)
  "v1.0.0-beta.17"
  Process GLTFBufferParser and GLTFTextureParser pipelines in parallel (galacean#1638)
  Fix animation clip loader, clip change promise to assetPromise, controller json parse (galacean#1506)
  fix: the layer is not cloned when the node is cloned (galacean#1636)
  Fix glTF texture mipmap bug (galacean#1637)
  "v1.0.0-beta.16"
  Adjust main light to directional lights first (galacean#1635)
  Fix  `AmbientLight` can't destroy bug (galacean#1633)
  ...
@singlecoder singlecoder mentioned this pull request Oct 9, 2023
Closed
@singlecoder singlecoder linked an issue Oct 9, 2023 that may be closed by this pull request
TextRenderer bug #1775
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@cptbtptpbcptdtptp cptbtptpbcptdtptp cptbtptpbcptdtptp approved these changes

@jtabibito jtabibito jtabibito approved these changes

Assignees

@singlecoder singlecoder

Labels
bug Something isn't working text 2D text system
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

TextRenderer bug
4 participants
@singlecoder @GuoLei1990 @cptbtptpbcptdtptp @jtabibito