From 014ec74f26860a17ae3e5bf71a2948efca17734b Mon Sep 17 00:00:00 2001 From: zhuxudong Date: Mon, 4 Sep 2023 18:26:42 +0800 Subject: [PATCH] chore: add comment --- packages/core/src/shaderlib/pbr/ibl_frag_define.glsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/shaderlib/pbr/ibl_frag_define.glsl b/packages/core/src/shaderlib/pbr/ibl_frag_define.glsl index 2a91bde346..99ed5045e6 100644 --- a/packages/core/src/shaderlib/pbr/ibl_frag_define.glsl +++ b/packages/core/src/shaderlib/pbr/ibl_frag_define.glsl @@ -34,7 +34,7 @@ vec3 envBRDFApprox(vec3 specularColor,float roughness, float dotNV ) { vec2 AB = vec2( -1.04, 1.04 ) * a004 + r.zw; - // warning: (iPhone XS iOS 14.4) may return negative value. + // warning: add `max` because (iPhone XS iOS 14.4) may return negative value, refer to issue: https://github.com/galacean/engine/pull/1728 return max(specularColor * AB.x + AB.y, 0.0); }