Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tests to Jest #96

Open
okonet opened this issue Oct 6, 2017 · 4 comments
Open

Switch tests to Jest #96

okonet opened this issue Oct 6, 2017 · 4 comments
Assignees
Milestone

Comments

@okonet
Copy link
Collaborator

okonet commented Oct 6, 2017

I believe this will make contributions to this project easier. Recently I created a PR and wanted to add some tests but noticed that there are no tests for any interactions yet so I would need to make a choice of a mocking framework (Sinon?) but ideally I'd just jump into writing tests. Jest comes as a feature-reach testing framework that has everything needed to test React components bundled (snapshot testing is amazing BTW, mocking, promises etc.).

Would you consider switching to Jest if I would create a PR?

@gabrielbull
Copy link
Owner

Hi okonet, yes I would be open to switching to Jest. When I first created this project, I had not used Jest, but since then, I have and think it would be a good idea as well. Bring on the PR. Would you like to be part of this project as a maintainer, I am looking for help since my time is very limited?

@okonet
Copy link
Collaborator Author

okonet commented Nov 6, 2017

Hey @gabrielbull! I'll try to do my best but maintaining one more project is off the table since I'm also fighting for me free time now.

@okonet
Copy link
Collaborator Author

okonet commented Nov 6, 2017

By saying that I mean I wouldn't not take over it but I could be involved in some discussions. So up to you if you want to invite me as a member or not :)

@gabrielbull
Copy link
Owner

Invited you, so now its your responsibility 🏃‍♂️ (runs away). J/K but any help is welcome at this point.

@gabrielbull gabrielbull added this to the Beta 0.4.0 milestone Jan 31, 2018
@alacroix alacroix self-assigned this Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants