Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cnv translator supports uncertain ranges for g. and m. #387

Merged
merged 2 commits into from
Apr 10, 2024
Merged

feat: cnv translator supports uncertain ranges for g. and m. #387

merged 2 commits into from
Apr 10, 2024

Conversation

korikuzma
Copy link
Contributor

@korikuzma korikuzma commented Apr 5, 2024 •
edited
Loading

close #381

Since we are waiting on HGVS PR to be merged, I used main-draft as the base branch.

@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Apr 5, 2024
@korikuzma korikuzma self-assigned this Apr 5, 2024
@korikuzma korikuzma requested review from a team as code owners April 5, 2024 20:57
larrybabb
larrybabb requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to you. The code looks fine and works the way you have it (afaic). But I did place a request (which can be deferred to a future issue) if you want.

src/ga4gh/vrs/extras/translator.py Show resolved Hide resolved
src/ga4gh/vrs/extras/translator.py Show resolved Hide resolved
@larrybabb larrybabb merged commit 20133b6 into main-draft Apr 10, 2024
8 checks passed
@larrybabb larrybabb deleted the issue-381 branch April 10, 2024 18:07
This was referenced Apr 10, 2024
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larrybabb larrybabb larrybabb approved these changes

Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @larrybabb