cleanup: add pre-commit + resolve pylint warnings #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolved easy pylint warnings * For those that had `too-many` warnings, I just disabled * Disable `fixme` for pylint * Name changes for variable names / imports
jsstevenson
approved these changes
Jul 11, 2023
|
@jsstevenson We have #153 . Did we want to completely ignore or up the max that we'd allow? I'm fine with either |
|
@korikuzma in my opinion (having thought about it for maybe... 90 seconds?), I think "too few public methods" just isn't a useful check for this codebase, and personally I'd be happy to blanket-ignore it. I looked again at the "too many locals" example and I think it's fine to leave it at the default value for now. It'd be nice to go through en masse (maybe at a future hackathon or during a free week) and try to make refactors to really resolve these issues rather than just ignoring them. |
jsstevenson
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #139 and #149