Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version on PyPi out of date, raises AttributeError on parse_headers #12

Open
jbrockmendel opened this issue Oct 29, 2016 · 3 comments
Open

Comments

@jbrockmendel
Copy link

As of 2016-10-29, the rfc6266 package on PyPi (https://pypi.python.org/pypi/rfc6266) is dated 2013-11-13. There is a typo in that version that has been fixed in the version on Github. Line 28 reads:

LOGGER.addHandler(logging.NullHandler)

instead of:

LOGGER.addHandler(logging.NullHandler())

So the call to LOGGER.debug inside parse_headers raises an AttributeError.

@mbarszcz
Copy link

@g2p Please let me know if I can help you out with releasing this -- this broke celery on our staging server today (it is executing .createLock() on all logging handlers and this fails for NullHandler class, but not instance).

@angelkenneth
Copy link

angelkenneth commented Jan 17, 2018

The version at pypi still has this line:

LOGGER.addHandler(logging.NullHandler)

instead of the latest:

LOGGER.addHandler(logging.NullHandler())

Great library, but please release a 0.0.5. So that we don't have to use rfc6266-parser.

@graingert
Copy link

@g2p there's another fork here https://github.com/ekzhu/rfc6266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants