Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to openmc API #71

Open
shimwell opened this issue Sep 20, 2022 · 2 comments
Open

Changes to openmc API #71

shimwell opened this issue Sep 20, 2022 · 2 comments
Assignees
@shimwell

Comments

@shimwell
Copy link
Member

This PR changes Muir to muir in the python API for openmc so we will need some changes on this package
@RemDelaporteMathurin
Copy link
Member

If I understand the Muir class is going to be replaced by a muir function returning a Normal class.

@shimwell
Copy link
Member Author

Yep that is right, we will just need to replace Muir with muir in the code.

When v0.14.0 gets released use if Muir will still work but print a warning message

@shimwell shimwell self-assigned this Mar 29, 2023
@shimwell shimwell mentioned this issue Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shimwell shimwell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shimwell @RemDelaporteMathurin