Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to sponsorship packet stuff #16

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Tookmund
Copy link
Contributor

Looking to redeploy this as we begin to ramp up for our next hackathon, I realize I never submitted these fixes upstream, so I'm doing that now.

Firstly, it seems there was code added to shared/packet.py to handle getting the packet file path, but it wasn't used when attaching the packet to the email.

Second, I set a default value for the location of the sponsorship packet in website/static so that I didn't have to set this when I was just getting the packet from a URL. This allows for easier first-time configuration, but also leaves the current level of configurability if desired.

Copy link
Member

@jwoglom jwoglom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Please feel free to send more improvements upstream :)

@Tookmund
Copy link
Contributor Author

If/when this is merged, there's a minor documentation update that should come with it
https://github.com/ACMWM/hackerforce/wiki/Environment-Variables

diff --git a/Environment Variables.md b/Environment Variables.md
index 8bcd71e..07c50ce 100644
--- a/Environment Variables.md  
+++ b/Environment Variables.md  
@@ -45,4 +45,4 @@ does not exist in the filesystem.
 The local name of the sponsorship packet, to be stored in the website/static
 folder. If this file exists, it will be used. Otherwise, it will be
 re-downloaded from `SPONSORSHIP_PACKET_URL`.
-Must be set regardless of whether `SPONSORSHIP_PACKET_URL` is set.
+It defaults to `sponsorship.pdf`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants