Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package is out of date #90

Open
mklaber opened this issue Apr 7, 2015 · 3 comments
Open

npm package is out of date #90

mklaber opened this issue Apr 7, 2015 · 3 comments

Comments

@mklaber
Copy link

mklaber commented Apr 7, 2015

Not sure why, but the dist file that npm spits out different than the one in master. Specifically, it's missing https://github.com/fullscale/elastic.js/blob/master/dist/elastic.js#L15769-L15772

This should fail to find anything via grep:

curl -O http://registry.npmjs.org/elastic.js/-/elastic.js-1.2.0.tgz
tar -zxvf elastic.js-1.2.0.tgz
grep 'fast-vector-highlighter' package/dist/elastic.js

(registry.npmjs.org URL comes from the dist.tarball property in the package.json file npm install elastic.js grabs)

@timcroydon
Copy link

Yes, I found a few missing features introduced after the last release version. At present, as a workaround, I'm using the following line in my package.json to load the latest code, using npm's native GitHub support (see https://docs.npmjs.com/files/package.json#github-urls):

"elastic.js": "fullscale/elastic.js#b29b7d2"

@dmitryt
Copy link

dmitryt commented Dec 15, 2017

I want to mention here, that version 1.1.1 doesn't contain all files from dist folder.
That's because files in package.json looks like this:

"files": [
    "elastic-node-client.js",
    "elastic.js"
  ],

@sudo-suhas
Copy link

@dmitryt, @mklaber, @timcroydon This library hasn't been updated in years. You could try elastic-builder if you are using elasticsearch@2 or higher. You can also try it out in the online playground - https://elastic-builder.js.org/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants