Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul parameter getter #46

Open
fabianfreyer opened this issue Jan 12, 2019 · 0 comments
Open

Overhaul parameter getter #46

fabianfreyer opened this issue Jan 12, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@fabianfreyer
Copy link
Contributor

We should probably not filter parameters at this time:

libjail-rs/src/param.rs

Lines 833 to 844 in 1f1e1d9

// The following parameters are dynamic
.filter(|name| name != "jid")
.filter(|name| name != "dying")
.filter(|name| name != "parent")
.filter(|name| name != "children.cur")
.filter(|name| name != "cpuset.id")
// The following parameters are handled separately
.filter(|name| name != "name")
.filter(|name| name != "hostname")
.filter(|name| name != "path")
.filter(|name| name != "ip6.addr")
.filter(|name| name != "ip4.addr")

@fabianfreyer fabianfreyer added enhancement New feature or request help wanted Extra attention is needed labels Jan 12, 2019
@fabianfreyer fabianfreyer added this to the 0.0.7 milestone Jan 12, 2019
@fabianfreyer fabianfreyer modified the milestones: 0.0.7, 0.0.8 May 26, 2019
@fabianfreyer fabianfreyer modified the milestones: 0.2.0, Future Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant