Better double asterisk support #769
Conversation
john-jam
force-pushed
the
better-double-asterisk-support
branch
from
2f79237
to
a9044a9
Compare
| with fsspec.open("mine/oi", "rb") as f: | ||
| with fsspec.open( | ||
| "s3://mine/oi", "rb", client_kwargs={"endpoint_url": endpoint_uri} | ||
| ) as f: |
There was a problem hiding this comment.
This test is unrelated to glob double asterisk but I think it was wrong. It tested the LocalFileSystem implementation instead of the S3 one.
|
|
||
| assert s3.ls(test_bucket_name) == s3.find( | ||
| ls_output = s3.ls(test_bucket_name) | ||
| assert sorted(ls_output + [test_bucket_name]) == s3.find( |
There was a problem hiding this comment.
find now returns the current folder as well.
| @@ -969,6 +969,8 @@ async def _ls(self, path, detail=False, refresh=False, versions=False): | |||
| for o in files | |||
| if o["name"].rstrip("/") == path and o["type"] != "directory" | |||
| ] | |||
| if not files: | |||
| raise FileNotFoundError(path) | |||
There was a problem hiding this comment.
Should raise FileNotFoundError when no files are found to be consistent.
|
@martindurant @ianthomas23 Since the upstream PR has been merged, the CI should succeed now. EDIT: there's an import error for common glob edge case tests. This PR should fix it: fsspec/filesystem_spec#1339 |
|
rerunning |
|
@martindurant Thanks for the rerun. Merging this PR should then fix the |
This PR updates the
s3fsimplementation to support updates made in the Better double asterisks ** support pull request in thefilesystem_specrepo.Successful run: https://github.com/fsspec/filesystem_spec/actions/runs/5847462518/job/15915309957