Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve async scheduling #14

Closed
d70-t opened this issue May 4, 2022 · 1 comment
Closed

improve async scheduling #14

d70-t opened this issue May 4, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@d70-t
Copy link
Collaborator

d70-t commented May 4, 2022

As noted in #12, the async implementation can be slower than the sync implementation in some cases. This should not be.

The MultiGateway sends requests to multiple gateways, trying to balance between them based on how fast they respond and if they explicitly mention that requests are coming in too quick (HTTP status 429). This happens for two purposes: automatic fall back from broken to live gateways and to be nice to (especially public) gateways.

It seems like the current scheduling strategy is not yet very good, leads to bad performance and should be updated.

@d70-t d70-t added enhancement New feature or request help wanted Extra attention is needed labels May 4, 2022
@d70-t
Copy link
Collaborator Author

d70-t commented Oct 14, 2024

With the revised implementation in ipfsspec>=0.5.0, MultiGateway doesn't exist anymore and thus the problem of scheduling is gone as well. Hence, I'll close the issue.

@d70-t d70-t closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant