Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse 4.0.2 version specifier for attrs too relaxed #1039

Closed
MarkCallow opened this issue Jul 7, 2024 · 3 comments · Fixed by #1044
Closed

reuse 4.0.2 version specifier for attrs too relaxed #1039

MarkCallow opened this issue Jul 7, 2024 · 3 comments · Fixed by #1044

Comments

@MarkCallow
Copy link

MarkCallow commented Jul 7, 2024 •
edited
Loading

reuse 4.0.2 specifies attrs>=21.1. When I pip install reuse on a Travis-CI Ubuntu Jammy (22.04) runner pip tells me "already satisfied by attrs version 21.2 in /usr/lib/python3/dist-packages". But when I run reuse it errors out with ModuleNotFound for attrs.

When I run on my local Ubuntu Jammy, attrs 23.2 is installed and reuse works. So I added pip3 install --upgrade attrs to our Travis-CI script. attrs is upgraded to 23.2 and reuse works.

Conclusion: reuse 4.0.2 needs a newer version of attrs than 21.2; its version specifier is wrong.
@MarkCallow MarkCallow changed the title reuse 4.0.2 version specifier for attrs too relaxed reuse 4.0.2 version specifier for attrs too relaxed Jul 7, 2024
@MarkCallow MarkCallow mentioned this issue Jul 7, 2024
Merged
MarkCallow added a commit to KhronosGroup/KTX-Software that referenced this issue Jul 7, 2024
@MarkCallow
Build fixes (#928)
f3b219d 
Upgrade the slightly old`attrs` package on Travis-CI to fix reuse 4.0.2 failure
due to fsfe/reuse-tool#1039.

Update iOS deployment target to 12.0 so Xcode 15 can be used for builds.
@carmenbianca carmenbianca mentioned this issue Jul 8, 2024
Merged
3 tasks
@carmenbianca
Copy link
Member

Fixed in #1044, thank you!

@carmenbianca
Copy link
Member

Released as v4.0.3

@MarkCallow
Copy link
Author

Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase minimum version of attrs carmenbianca/reuse-tool
2 participants
@MarkCallow @carmenbianca