Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this project alive ?? #22

Closed
pedromorgan opened this issue Nov 23, 2020 · 14 comments
Closed

is this project alive ?? #22

pedromorgan opened this issue Nov 23, 2020 · 14 comments

Comments

@pedromorgan
Copy link

Am a bit worries with PR's and issues...

  • is this another dead project ??

see #21

@abitrolly
Copy link
Contributor

I guess paying to free some of the @fschulze time could solve the problem for now.

@fschulze
Copy link
Owner

It would, or someone takes over maintenance.

@RagingRoosevelt
Copy link
Collaborator

I can't volunteer to totally take over maintenance but I'd be willing to help. I'm trying to come up to speed on the codebase to be able to submit a PR for #24 and #25. I'd be willing to help review PRs, etc if that were helpful. Would it make sense to move the repo to an organization to facilitate bringing on help?

@fschulze
Copy link
Owner

@RagingRoosevelt Thanks for the offer!

For now any PR which can be readily merged would already be of much help. A good PR either has a test for the bug or feature, or a good explanation on the what and why if a test doesn't make sense for some reason. A changelog entry if it isn't something minor or internal. For this project I don't require documentation, but it would always be nice to improve that.

Also helping with issues/PRs by commenting when there is information missing or how to make a PR mergable.

If necessary it is easy to add you as a collaborator on this repo without an organization.

Oh and if you know how, it would be great to move to GitHub Actions for tests, otherwise I will do it whenever I get to it. Just for reference: I did it recently for https://github.com/devpi/devpi/, but the setup is quite a bit more complex than what we need here, but the required bits and pieces are in there.

@RagingRoosevelt
Copy link
Collaborator

Finally added that PR I promised! Still l need to do the other.

@abitrolly
Copy link
Contributor

@fschulze I replaced malfunctioning Travis CI with GitHub Actions in #28. They pass in my fork https://github.com/abitrolly/schemadisplay but tox.ini needs Python 3 to be added to environments. Hopefully that brings possible release a little closer. I can help with releasing as well. Not sure about reviewing PRs though. If something is not covered by tests, I probably won't be able to grok the logic behind.

@abitrolly
Copy link
Contributor

Test are merged. ) Need to check which tox.ini environments are actual and add Python 3 there. @fschulze can we make a checkpoint release once all tests pass?

@abitrolly
Copy link
Contributor

In #29 Python 3 tests fail, but work fine on Python 2.7. Looking into how to fix them.

image

@abitrolly
Copy link
Contributor

Test are fixed in #29. Should be good to go now.

@fschulze
Copy link
Owner

fschulze commented Aug 3, 2022

I merged and fixed #30 to make the release process easier.

@abitrolly
Copy link
Contributor

@fschulze thanks! I've just I started to walk down the slippery road of vendoring dependencies, and now I can relax and chill a bit. :D

It is safe to get prereleases to PyPI - pip won't propose to install them unless explicitly requested if a stable version is available - https://pip.pypa.io/en/stable/cli/pip_install/#pre-release-versions

sqlalchemy-schemadisplay-1.4.dev0 from TestPyPI works fine.

@abitrolly
Copy link
Contributor

Vendored and released cmdline wrapper as https://pypi.org/project/sqlite2png/

@Zlopez
Copy link
Collaborator

Zlopez commented Feb 19, 2024

I took over the project and did a new releases:

  • 1.4 for python27
  • 2.0 for python3 and SQLAlchemy 2.x

@Zlopez Zlopez closed this as completed Feb 19, 2024
@abitrolly
Copy link
Contributor

@Zlopez thanks a lot. That was a needed step to not lose the progress on DB diagramming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants