Allow for custom component #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setNativeProps = nativeProps => { | ||
| /* eslint no-underscore-dangle: 0 */ | ||
|
|
||
| this._root.setNativeProps(nativeProps); |
There was a problem hiding this comment.
This will not fix bug #12
Remove this method.
Please add me as collaborator and I will fix that issue in separate pull request.
There was a problem hiding this comment.
Sure thing, I probably misunderstand you on this. Feel free to work on this branch directly if you want to 🙂
There was a problem hiding this comment.
Great! Thanks! I will add fix later today.
serhiipalash
requested changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows for custom components fixing #9. It also includes a fix for #12.