This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Feature prepare environment script #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 72.91% (diff: 100%)@@ master #172 diff @@
==========================================
Files 1 1
Lines 882 875 -7
Methods 0 0
Messages 0 0
Branches 153 150 -3
==========================================
- Hits 640 638 -2
+ Misses 198 195 -3
+ Partials 44 42 -2
|
| @@ -0,0 +1,111 @@ | |||
| from __future__ import print_function | |||
There was a problem hiding this comment.
The rest of the clcache script code now requires Python 3.3 or newer. I think imposing the same requirement here would be consistent, and it would simplify things abit (e.g. this import is not needed).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for Visual Studio usage looks several complicated and not convenient.
I wrote script which modify installed Visual Studio toolsets by prepending ExecutablePath with directory contains clacache executable. Also script sets system environment variables CLCACHE_DIR and CL.
I'm not sure my approach too perfect, but ideas can by useful.