Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow a default port in URLs by default #85

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Don't allow a default port in URLs by default #85

merged 1 commit into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. Remove default port 

    Allow client implementors to set a default port for gRPC URLs via the
`defaults` argument but make the `parse_grpc_uri` function and
`BaseApiClient` class don't provide a default port unless explicitly
set by the implementors, as using a default port really depends on the
specific API being implemented.

Signed-off-by: Leandro Lucarella <[email protected]>
    @shsms @llucax
    shsms authored and llucax committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    81405db View commit details
    Browse the repository at this point in the history