Use netloc from urlparse to specify the host
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because `netloc` is formatted to be the network location, and wraps ipv6 in square brackets, which we lose if we just use the `host` field. `netloc` also contains the port if a port was in the original uri. We need to append the default port only if the original uri didn't have a port. This fixes an issue when creating a grpc Channel with ipv6 addresses. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
llucax
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because
netlocis formatted to be the network location, and wraps ipv6 in square brackets, which we lose if we just use thehostfield.netlocalso contains the port if a port was in the original uri. We need to append the default port only if the original uri didn't have a port.This fixes an issue when creating a grpc Channel with ipv6 addresses.