Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a default port for creating grpcio channels #80

Closed
shsms opened this issue Sep 3, 2024 · 0 comments · Fixed by #85
Closed

Don't use a default port for creating grpcio channels #80

shsms opened this issue Sep 3, 2024 · 0 comments · Fixed by #85
Labels
part:code Affects the code in general type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@shsms
Copy link
Contributor

shsms commented Sep 3, 2024

What's needed?

We currently use a default port of 9090 if incoming URIs don't specify a port. This is confusing, because grpc doesn't have a default port, and we might even inadvertently connect to a different service.

Proposed solution

There should be no default port, and if a URI doesn't specify a port, we should raise an exception immediately after parsing it.

@shsms shsms added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Sep 3, 2024
@shsms shsms changed the title Remove default port when creating channels Don't use a default port for creating grpcio channels Sep 3, 2024
@llucax llucax added this to the v0.7.0 milestone Sep 3, 2024
@llucax llucax added part:code Affects the code in general and removed part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed labels Sep 3, 2024
@llucax llucax linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:code Affects the code in general type:enhancement New feature or enhancement visitble to users
Projects
None yet
2 participants