Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client attribute to ApiClientError #77

Open
llucax opened this issue Aug 27, 2024 · 0 comments
Open

Add a client attribute to ApiClientError #77

llucax opened this issue Aug 27, 2024 · 0 comments
Assignees
Labels
part:code Affects the code in general type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Aug 27, 2024

What's needed?

The ApiClientError will be used to report errors for many different types of clients, so we need an easy way to map an error to a particular client.

The error already saves the server_url, which could be potentially used for that, but if for some reason any user wants to instantiate 2 clients with the same URL, this won't be enough.

Proposed solution

Save a client property in the error instance too, pointing to the API client that generated the error.

@llucax llucax added type:enhancement New feature or enhancement visitble to users part:code Affects the code in general labels Aug 27, 2024
@llucax llucax added this to the v0.7.0 milestone Aug 27, 2024
@llucax llucax self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:code Affects the code in general type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

1 participant