Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth key support #70

Open
llucax opened this issue Aug 14, 2024 · 0 comments
Open

Add auth key support #70

llucax opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
part:code Affects the code in general priority:high Address this as soon as possible type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Aug 14, 2024

What's needed?

We need to add an auth key to every request for authorization.

Proposed solution

Make the BaseApiClient take a key in the constructor and automatically pass the keys to stub methods.

Use cases

No response

Alternatives and workarounds

No response

Additional context

Example implementation:

But maybe we can use the AuthMetadataPlugin:

@llucax llucax added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users priority:high Address this as soon as possible part:code Affects the code in general and removed priority:❓ We need to figure out how soon this should be addressed part:❓ We need to figure out which part is affected labels Aug 14, 2024
@llucax llucax modified the milestones: v0.7.0, v0.6.0 Aug 14, 2024
@llucax llucax self-assigned this Aug 20, 2024
@llucax llucax modified the milestones: v0.6.0, v0.7.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:code Affects the code in general priority:high Address this as soon as possible type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

1 participant