falter-berlin-autoupdate: if possible, use --ignore-minor-compat-version #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akira25
force-pushed
the
144_autoupdate_ignore_compat
branch
from
18dea0a
to
19aadea
Compare
The option `--ignore-minor-compat-version` enables the sysupgrade command to do an update also in case, there is a minor compat-version upgrade. This is relevant for the change from swconfig to dsa. Signed-off-by: Martin Hübner <[email protected]>
Akira25
force-pushed
the
144_autoupdate_ignore_compat
branch
from
19aadea
to
f3f50d7
Compare
13 tasks
|
Why do we want to ignore the jump in Combat Version if the (custom) config from the router will likely not work after it? Just asking to understand your PR better as you requested a review from me. |
|
We want to ignore minor compat-version jumps only. This is needed i.e. for the devices changing from swconfig to DSA. They are incompatible at first glance, but we can migrate that case automatically. I was told, that Gluon did something similar already. @Noki / @pktpls and I agreed on this at the Community day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
--ignore-minor-compat-versionenables the sysupgrade command to do an update also in case, there is a minor compat-version upgrade. This is relevant for the change from swconfig to dsa.Compile tested: no.
Run tested: Yes, on a Archer-C5v1 w/ Falter 1.2.3 (OpenWrt-21.02) and mikrotik_routerboard-750gr3 w/ OpenWrt-23.05