Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag collision due to tag calculation #15

Open
Muriano opened this issue Nov 27, 2023 · 1 comment
Open

Tag collision due to tag calculation #15

Muriano opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Muriano
Copy link
Contributor

Muriano commented Nov 27, 2023

The way we calculate tag prefix now (we take value from current dir) can generate collisions when we have complex folder structures like:

images/
    php81/
        cli/
            .version.json
        web/
            .version.json
    php82/
        cli/
            .version.json
        web/
            .version.json

This folder struc, that in actually real, create 2 pairs of tags prefixed with cli and web.

I suggest to provide a way to configure custom prefixes for each .version.json file.

@Muriano Muriano self-assigned this Nov 27, 2023
@Muriano Muriano added the enhancement New feature or request label Nov 27, 2023
@sergiotejon
Copy link
Contributor

Is this feature already implemented with our current --prefix flag? I ask this to close this is issue if it's done. @Muriano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants