Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs when PR-CI is unable to parse the definitions file #326

Open
netoarmando opened this issue Nov 28, 2019 · 0 comments
Open

Improve logs when PR-CI is unable to parse the definitions file #326

netoarmando opened this issue Nov 28, 2019 · 0 comments

Comments

@netoarmando
Copy link
Member

E.g., when the symlink is pointing to an invalid file this is what PR-CI logs display:

"Nov 28 12:51:02 small-runner-19 bash[937]: INFO: __main__: Skipping PR#3: can't be merged",
"Nov 28 12:51:02 small-runner-19 bash[937]: INFO: __main__: Skipping PR#7: can't be merged",
"Nov 28 12:51:02 small-runner-19 bash[937]: INFO: __main__: Skipping PR#31: can't be merged",
"Nov 28 12:51:02 small-runner-19 bash[937]: INFO: __main__: Skipping PR#67: can't be merged",
"Nov 28 12:51:03 small-runner-19 bash[937]: ERROR: __main__: string indices must be integers"

PR number 82 was the culprit, but there is no way to know that, only to infer based on the previous lines and going to the list of open PRs to see which would be the next after number 67.

Related to #257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant