Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check subkey fingerprints in SDWConfigValidator #1169

Open
1 task done
rocodes opened this issue Sep 4, 2024 · 0 comments
Open
1 task done

Check subkey fingerprints in SDWConfigValidator #1169

rocodes opened this issue Sep 4, 2024 · 0 comments

Comments

@rocodes
Copy link
Contributor

rocodes commented Sep 4, 2024

  • I have searched for duplicates or related issues

Description

QA report: If a subkey is used as the Submission Private Key, the SDWConfigValidator fails with the message "Configured fingerprint does not match key" because the subkey fingerprints are not checked.

Steps to Reproduce

Configure testing PGP key with subkey. Note subkey fingerprint. Export armored secret keys (sd-journalist.sec). Provision config.json with the subkey fingerprint. Run validator.

Expected Behavior

(Needs discussion) - I would expect this to pass validation, even though our docs don't suggest this setup.

Actual Behavior

Validator fails as described above.

Comments

Including the --with-subkey-fingerprints flag on this line will allow this configuration to pass the validator.

gpg_cmd = ["gpg2", "--show-keys", self.secret_key_filepath]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant