-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teach vcrpy
our proxy v2 request/response semantics
#1778
Comments
vcrpry
our request/response semanticsvcrpry
our proxy v2 request/response semantics
We know that requests look like: securedrop-client/client/securedrop_client/sdk/__init__.py Lines 160 to 169 in f8c1f54
And responses look like either of: securedrop-client/client/securedrop_client/sdk/__init__.py Lines 74 to 85 in f8c1f54
So, working backwards:
|
vcrpry
our proxy v2 request/response semanticsvcrpy
our proxy v2 request/response semantics
This is well underway in Next up is to deduplicate |
This is implemented in f3a5c5a...b82720b. The diffstat looks horrific ( Commits are marked |
This will be reviewed as part of #1718. |
Tests need fixing, they're currently using
vcr
. We either need to reimplement vcr for our mock format or mock the proxying to use requests and then keep using vcr.Originally posted by @legoktm in #1718 (comment)
The text was updated successfully, but these errors were encountered: