Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecked runtime error on ICMP message #77

Open
kennysong opened this issue Jun 17, 2015 · 0 comments
Open

Unchecked runtime error on ICMP message #77

kennysong opened this issue Jun 17, 2015 · 0 comments

Comments

@kennysong
Copy link
Member

In uproxy_core.ts, there's a new function called getNetworkInfo() that probes the user's router for details about its NAT configuration. Since we don't have a reliable way of finding the router's internal IP, we just test a list of popular router IPs (see line 354).

Sometimes, if you run getNetworkInfo() repeatedly, some of these router IPs will return an ICMP error of:

Type: 3 (Destination unreachable)
Code: 13 (Communication administratively filtered)

This results in a error being logged in the Chrome console:

screen shot 2015-06-17 at 11 01 09 am

Is it possible to handle this error in the freedom socket module so that it doesn't appear in the console?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant