Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add Google Search functionality to more search engines #2

Open
SlyAceZeta opened this issue Dec 31, 2022 · 9 comments
Open
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@SlyAceZeta
Copy link
Contributor

The two that immediately come to mind are DuckDuckGo and Bing.

@SlyAceZeta SlyAceZeta changed the title Add Google Search functionality to more search engines Suggestion: add Google Search functionality to more search engines Dec 31, 2022
@alex4401 alex4401 added the feature New feature or request label Jan 1, 2023
@alex4401 alex4401 self-assigned this Jan 1, 2023
@alex4401
Copy link
Collaborator

alex4401 commented Jan 3, 2023

Started some work on this, but Google filter needs an update first as they're doing an A/B on search results format.
image

@alex4401 alex4401 added the help wanted Extra attention is needed label Jan 3, 2023
@alex4401
Copy link
Collaborator

alex4401 commented Jan 3, 2023

Doesn't look like it'll be possible to implement support for Bing, as they heavily obfuscate their links as part of click tracking - therefore the help wanted label. DDG seems straightforward though.

@alex4401
Copy link
Collaborator

As an update, I've got a prototype for DuckDuckGo but am not exactly happy with it: DDG's web interface is rendered primarily with JavaScript, and as I intended to use isolated content scripts (as I should in Manifest V3 land) DDG's (quite clean but private) API is inaccessible.
The "better" method requires script injection with no isolation. But relying on the JS interfaces which may change at any time does sound like asking for trouble.

@alex4401 alex4401 added this to the v1.7.0 milestone Jun 27, 2023
@alex4401
Copy link
Collaborator

DuckDuckGo is being worked on in #16.

@Mach565
Copy link

Mach565 commented Jan 17, 2024

I would like to request support for Startpage too, if it's not too much of a hassle.

@SnorlaxMonster
Copy link

Doesn't look like it'll be possible to implement support for Bing, as they heavily obfuscate their links as part of click tracking - therefore the help wanted label.

On Bing, the original URL can be retrieved from the u parameter in the Bing URL, by removing the a1 prefix and decoding it as Base64.

This same problem came up for Indie Wiki Buddy KevinPayravi/indie-wiki-buddy#448. Using this approach has allowed the extension to work successfully on Bing.

As noted by various users on this Stack Overflow post, it's unclear what the significance of a1 is, and what should be done if the prefix happens to be something other than a1.

@alex4401
Copy link
Collaborator

Thank you, that's good to know.

@alex4401 alex4401 removed this from the v1.7.0 milestone Feb 16, 2024
@Clayblockunova
Copy link
Contributor

when will Bing filter be finished? should we add extra optimization for CN Bing?

@alex4401
Copy link
Collaborator

alex4401 commented Jun 9, 2024

The contributor who started implementing it seems to have stalled the work. I'm currently swarmed with other projects and university, so it may take a while before I'm able to take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants