Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use contextmanager for reading files #2025

Closed
mfranzon opened this issue Nov 8, 2024 · 0 comments · Fixed by #2032
Closed

use contextmanager for reading files #2025

mfranzon opened this issue Nov 8, 2024 · 0 comments · Fixed by #2032
Labels
maintenance task collection

Comments

@mfranzon
Copy link
Collaborator

mfranzon commented Nov 8, 2024

for example here

fractal-server/fractal_server/tasks/v2/utils_background.py

Line 170 in ae753e0

task_group_activity.log = log_file_path.open("r").read()

@tcompa tcompa linked a pull request Nov 11, 2024 that will close this issue
Remove last open().read() left #2032
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance task collection
Projects
Fractal Project Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove last open().read() left fractal-analytics-platform/fractal-server
2 participants
@tcompa @mfranzon