Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log/handle failure when zipping (large) job folder #1954

Open
tcompa opened this issue Oct 23, 2024 · 0 comments
Open

Log/handle failure when zipping (large) job folder #1954

tcompa opened this issue Oct 23, 2024 · 0 comments
Assignees

Comments

@tcompa
Copy link
Collaborator

tcompa commented Oct 23, 2024

Ref https://github.com/fractal-analytics-platform/fractal-server/blob/main/fractal_server/zip_tools.py#L125.

We did observe the creation of a zip file (for a large folder of ~900 MB) which probably failed, since unzipping it leads to

End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.

If _create_zip fails, we should at the very least:

  • emit an error log
  • remove the corrupted archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants